Removed pydantic V2 protected messages to avoid unnecessary warnings to users #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabefire
force-pushed
the
gu/pydantic_remove_depercated_messages
branch
from
f824abe to
2bd2c7f
Compare
vbrodsky
reviewed
Sep 9, 2024
| @@ -24,7 +24,8 @@ class RasterData(BaseModel, ABC): | |||
| uid: Optional[str] = None | |||
| global_key: Optional[str] = None | |||
| arr: Optional[TypedArray[Literal['uint8']]] = None | |||
| model_config = ConfigDict(extra="forbid", copy_on_model_validation="none") | |||
|
|
|||
| model_config = ConfigDict(extra="forbid") | |||
There was a problem hiding this comment.
why was copy_on_model_validation removed
There was a problem hiding this comment.
Pydantic V2 removed it :( with no alternative
There was a problem hiding this comment.
It throws a warning to users if you import this library and technically does nothing
There was a problem hiding this comment.
This is what it used to do. We don't have a way to add this behavior anymore but Im not sure why the original author added this setting it is the only place that includes this in the config settings
vbrodsky
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
model_, it will spam the user with a protected message. You can avoid this message by inside the config dict https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.protected_namespacesType of change
Please delete options that are not relevant.
All Submissions